Fix confusion of the root-node when validating a signature - #424
Open
tvdijen wants to merge 2 commits into
Open
Conversation
tvdijen
marked this pull request as ready for review
August 15, 2026 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When unmarshalling an unsigned response containing a signed assertion, the validation of the assertion's signature fails.
This is because of the document we pull in this line of code:
https://github.com/simplesamlphp/xml-security/blob/master/src/XML/SignedElementTrait.php#L139
.. and because of what we pass to
Assertion::setXML().Before this change we would pass the entire Response instead of just the Assertion. And because the Response is unsigned, the XPath-query
child::ds:Signatureyields no result, failing to pass the minCount-assertion.Verified this using
var_dump($xml->ownerDocument->documentElement->localName);after the referenced line 139. Before this change it returnedResponseand after it showsAssertion